Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Self in prop fields #3569

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Conversation

its-the-shrimp
Copy link
Contributor

Description

Fixes #3557

Checklist

  • I have reviewed my own code
  • I have added tests

Copy link

github-actions bot commented Dec 22, 2023

Visit the preview URL for this PR (updated for commit 87ac8b5):

https://yew-rs-api--pr3569-fix-self-in-props-zrbk8dxf.web.app

(expires Sat, 30 Dec 2023 11:24:12 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Copy link

github-actions bot commented Dec 22, 2023

Benchmark - SSR

Yew Master

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 289.322 295.055 289.999 1.783
Hello World 10 511.456 520.186 516.259 3.291
Function Router 10 1606.805 1660.998 1621.841 14.656
Concurrent Task 10 1005.997 1007.168 1006.489 0.385
Many Providers 10 1104.546 1151.029 1132.827 12.074

Pull Request

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 289.375 292.929 290.062 1.202
Hello World 10 495.686 512.628 502.123 6.770
Function Router 10 1619.039 1650.771 1633.158 10.157
Concurrent Task 10 1005.760 1007.225 1006.364 0.443
Many Providers 10 1118.401 1146.639 1131.391 9.812

Copy link

github-actions bot commented Dec 22, 2023

Size Comparison

examples master (KB) pull request (KB) diff (KB) diff (%)
async_clock 101.060 101.060 0 0.000%
boids 174.696 174.696 0 0.000%
communication_child_to_parent 93.479 93.479 0 0.000%
communication_grandchild_with_grandparent 106.455 106.455 0 0.000%
communication_grandparent_to_grandchild 101.720 101.720 0 0.000%
communication_parent_to_child 89.812 89.812 0 0.000%
contexts 106.571 106.571 0 0.000%
counter 86.854 86.854 0 0.000%
counter_functional 87.262 87.262 0 0.000%
dyn_create_destroy_apps 89.647 89.647 0 0.000%
file_upload 100.729 100.729 0 0.000%
function_memory_game 173.427 173.427 0 0.000%
function_router 350.793 350.793 0 0.000%
function_todomvc 162.219 162.219 0 0.000%
futures 230.407 230.407 0 0.000%
game_of_life 111.062 111.062 0 0.000%
immutable 188.415 188.415 0 0.000%
inner_html 80.555 80.555 0 0.000%
js_callback 110.321 110.321 0 0.000%
keyed_list 200.063 200.063 0 0.000%
mount_point 83.444 83.444 0 0.000%
nested_list 114.669 114.669 0 0.000%
node_refs 90.967 90.967 0 0.000%
password_strength 1751.752 1751.752 0 0.000%
portals 94.197 94.197 0 0.000%
router 319.600 319.600 0 0.000%
simple_ssr 141.322 141.322 0 0.000%
ssr_router 389.007 389.007 0 0.000%
suspense 116.542 116.542 0 0.000%
timer 89.318 89.318 0 0.000%
timer_functional 98.682 98.682 0 0.000%
todomvc 142.515 142.515 0 0.000%
two_apps 86.574 86.574 0 0.000%
web_worker_fib 135.578 135.578 0 0.000%
web_worker_prime 185.975 185.975 0 0.000%
webgl 83.117 83.117 0 0.000%

✅ None of the examples has changed their size significantly.

Copy link
Member

@futursolo futursolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Looks good to me.

Copy link
Member

@ranile ranile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ranile ranile merged commit 89c9dfe into yewstack:master Jul 25, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't use Self in generic when deriving Properties
3 participants