-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Namespace support for VRaw
.
#3640
Conversation
Benchmark - coreYew Master
Pull Request
|
Size Comparison
✅ None of the examples has changed their size significantly. |
Benchmark - SSRYew Master
Pull Request
|
Visit the preview URL for this PR (updated for commit 5073e33): https://yew-rs-api--pr3640-3639-vraw-namespace-hmd5u4yn.web.app (expires Sat, 30 Mar 2024 17:41:31 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI failures look unrelated, thanks for the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks clean to me. At some point we should think about internally passing down the namespace instead of grabbing it again by interacting with the DOM but I would need to convinced that it's considerable overhead first.
Description
Fixes #3641
When attaching
Html
to DOM, create the temporary parent with the same namespaceURI as the actual parent.Checklist
Unanswered questions