-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise MSRV to 1.76 #3693
Raise MSRV to 1.76 #3693
Conversation
Visit the preview URL for this PR (updated for commit 5f6d410): https://yew-rs-api--pr3693-msrv-hnsl5ib9.web.app (expires Fri, 09 Aug 2024 21:48:22 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from matching Tokio and Hyper, is there any other reason you chose this version? I had a look over the features of rust versions yesterday and didn't see any really important features we absolutely need, so I'm curious if you found something.
I had no major reason other than the fact that this includes lints that use/suppress (cause of unknown lint warning from previous code) and is newer than any before/after rustversion checks that we had |
@WorldSEnder another reason for update is allow dependencies to update. Yew takes quite a few dependencies and having those outdated could cause problems |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I think 1.76 is at this point almost 6 months old and has the ambiguous_wide_pointer_comparisons
lint that I remember previously causing unnecessary warnings in the CI for the MSRV version due to mismatch between this and the superseded clippy::vtable_address_comparisons
.
Description
Raise MSRV to 1.76
1.76 is (almost*) 6 months old so this change brings Yew's MSRV to the same as Tokio and Hyper.
* It will be 6 months old by first week of August so not a huge deal at the moment
Checklist