Fix check for URI length to prevent incorrect HTTP 414 errors #2046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brettp could you please add at least one unit text in |
httplib.h
Outdated
Comment on lines
7165
to
7170
| auto req_line = line_reader.ptr(); | ||
|
|
||
| // Extract URI from the request line | ||
| std::string method, uri, version; | ||
| std::istringstream iss(req_line); | ||
| iss >> method >> uri >> version; |
There was a problem hiding this comment.
This is effectively what parse_request_line() does. Shouldn't the check be moved there?
|
@yhirose - Test added for request lines larger than max URI length but with a URI itself that is shorter. @falbrechtskirchinger - I remove the extra parsing by checking the length of |
|
@brettp thanks for your fine contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the full stream's length, including POST data, is checked instead of just the URI. This results in false
414 URI Too Longerrors. The fix is to check only the URI part of the first line of the stream.