Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: conditionally output analysis JS only in Vercel environment #715

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

Liudon
Copy link
Contributor

@Liudon Liudon commented Sep 22, 2024

In non-Vercel deployment environments(Github Pages), there will be a 404 request for the Vercel Analytics JS.

WX20240922-194600@2x

After modification, output under Vercel deployment:

WX20240922-215504@2x

output non-Vercel deployment:

WX20240922-215720@2x

Copy link

vercel bot commented Sep 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
running-page ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2024 2:12pm

@yihong0618 yihong0618 merged commit d58493b into yihong0618:master Sep 25, 2024
6 checks passed
@yihong0618
Copy link
Owner

Thanks

ben-29 added a commit to ben-29/workouts_page that referenced this pull request Sep 29, 2024
* refs/heads/upstream:
  feat: fix nrc Changed their apis (yihong0618#718)
  feat: conditionally output analysis JS only in Vercel environment (yihong0618#715)
  ignore the year which has no running data when drawing github.svg (yihong0618#712)
  Fix AttributeError in Activity class (yihong0618#714)
  doc: fix typo close yihong0618#704
  Some Front Optimization for Keep indoor data (yihong0618#709)
  Add new runner (yihong0618#707)
  feat: adding illustration for special tracks  (yihong0618#705)

# Conflicts:
#	run_page/generator/__init__.py
#	run_page/joyrun_sync.py
jiantian99 pushed a commit to jiantian99/running_page that referenced this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants