Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: listen to fullscreenchange instead of onRender resize #729

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

orionna319
Copy link
Collaborator

@orionna319 orionna319 commented Oct 22, 2024

Related PR

When onRender calls resize, resize will not be triggered. Instead, listen for fullscreenchange

Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
running-page ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 4:12am

@orionna319
Copy link
Collaborator Author

Please click this link, this is a video of the steps to reproduce the bug

move-fullscreen-bug.mp4

Copy link
Owner

@yihong0618 yihong0618 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@yihong0618 yihong0618 merged commit b8e8fe1 into yihong0618:master Oct 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants