Richer activity title with more sport types and locations #733

NaturezzZ · 2024-11-10T17:32:38Z

The activity title by default use user-defined title in the activity. It can also be garmin-style location+sport type. BTW, it supports more types of sports, such as trail running, treadmill running, hiking, and etc.

FYI, an example website is shown in https://run.zhengnq.com

vercel · 2024-11-10T17:32:42Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
running-page	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 21, 2024 10:24am

yihong0618

seems we added a new column did it a break change?

run_page/gpxtrackposter/track.py

NaturezzZ · 2024-11-11T04:55:22Z

seems we added a new column did it a break change?

I'm not quite sure what you mean. There are no new columns added here, just more diverse sports titles.

yihong0618 · 2024-11-11T05:00:33Z

cool will take a look these days thanks

ben-29

The function is working perfectly, great job.
However, I have two concerns:

Is it possible to modify the default track name("none")?
The newly added column might break syncing for current users.

ben-29 · 2024-11-18T10:39:35Z

run_page/gpxtrackposter/track.py

-                f"run from {run_from} by {self.device}"
-                if self.device
-                else f"run from {run_from}"
+                self.track_name if self.track_name else "none"


For the default value, can we use "" instead of "none"?

Additionally, for names already synced in the db, please include instructions in the readme on enabling the feature for all data, possibly with a SQL, to reset names to default.

For the default value, can we use "" instead of "none"?

no problem

Additionally, for names already synced in the db, please include instructions in the readme on enabling the feature for all data, possibly with a SQL, to reset names to default.

It works if I remove all the caches and regenerate the running page completely. I am trying resolving problems on updating synced activities.

For the default value, can we use "" instead of "none"?

resolved in d9ae3ac

ben-29 · 2024-11-18T10:39:53Z

run_page/gpxtrackposter/track.py

            ),  # maybe change later
-            "type": "Run",  # Run for now only support run for now maybe change later
+            "type": self.type,
+            "subtype": (self.subtype if self.subtype else "none"),


done in d9ae3ac

ben-29 · 2024-11-18T11:12:38Z

run_page/generator/db.py

@@ -29,6 +29,7 @@ def randomword():
    "distance",
    "moving_time",
    "type",
+    "subtype",


This new column is not present in the SQLite file if the user syncs before this pull request. Users may face difficulties adding this column manually, or else syncing will fail. Perhaps you should add instructions in the readme or include a script to assist users in doing this easily, as seen in this ref1 ref2. There might be a simpler solution that I'm unaware of.

The db checks whether the new column exists after commit c86d040. If any column defined in class Activity does not exist, it will add a new column in data.db.

ben-29 · 2024-11-18T11:13:39Z

src/utils/utils.ts

 const titleForRun = (run: Activity): string => {
+  if (RICH_TITLE) {
+    // 1. try to use user defined name
+    if (run.name != 'none') {


Perhaps it's not a good default value?

NaturezzZ · 2024-11-18T12:21:19Z

The function is working perfectly, great job. However, I have two concerns:

Is it possible to modify the default track name("none")?

The newly added column might break syncing for current users.

Thanks for your review :) I will take a look in a few days, make changes and get back to you.

NaturezzZ · 2024-11-21T10:08:45Z

@ben-29 @yihong0618 This feature only applies to newly added activities; if there were some previous activities, their activity names won't change (they will be run from...), and the names displayed on the web page are still inferred by time and distance. If users want this to apply to all activities, they can simply delete the GitHub Action Cache.

ben-29

Well done

ben-29 · 2024-11-22T05:27:48Z

run_page/generator/db.py

@@ -135,10 +148,37 @@ def update_or_create_activity(session, run_activity):
    return created


+def add_missing_columns(engine, model):


NaturezzZ · 2024-11-22T06:12:36Z

Maybe we can consider setting default value of const RICH_TITLE = false to true, as users prefer to use the activity name they set themselves, or keep it consistent with their running app.

yihong0618

LGTM
That's cool

yihong0618 · 2024-11-24T07:17:31Z

Maybe we can consider setting default value of const RICH_TITLE = false to true, as users prefer to use the activity name they set themselves, or keep it consistent with their running app.

yes we can make it to another pull request

yihong0618 · 2024-11-25T08:19:14Z

@NaturezzZ
some issue our users found.

NaturezzZ · 2024-11-25T08:22:29Z

@NaturezzZ some issue our users found.

Try to delete data.db and all downloaded files. Plz let me know if it is still not working.

yihong0618 · 2024-11-25T08:23:50Z

@NaturezzZ some issue our users found.

Try to delete data.db and all downloaded files. Plz let me know if it is still not working.

copy that

NaturezzZ added 3 commits November 10, 2024 20:55

show activity name with more detailed type

d95b27a

Added a flag for whether to turn on rich activity titles

7d27837

reformat

b1c436c

vercel bot deployed to Preview November 10, 2024 17:33 View deployment

yihong0618 reviewed Nov 11, 2024

View reviewed changes

run_page/gpxtrackposter/track.py Outdated Show resolved Hide resolved

yihong0618 requested review from ben-29 and zhaohongxuan November 11, 2024 04:52

nits

55b7bb9

vercel bot deployed to Preview November 11, 2024 04:56 View deployment

use title from garmin

d34f4d9

vercel bot deployed to Preview November 11, 2024 14:25 View deployment

ben-29 reviewed Nov 18, 2024

View reviewed changes

fix duplicated gpx download in fit mode

a3d0314

vercel bot deployed to Preview November 21, 2024 09:08 View deployment

NaturezzZ added 2 commits November 21, 2024 17:56

add column if not exist

4b5bbdd

nits

c86d040

vercel bot deployed to Preview November 21, 2024 09:57 View deployment

vercel bot deployed to Preview November 21, 2024 09:58 View deployment

change track fallback name to ''

d9ae3ac

vercel bot deployed to Preview November 21, 2024 10:21 View deployment

nits

bed31c1

vercel bot deployed to Preview November 21, 2024 10:24 View deployment

ben-29 approved these changes Nov 22, 2024

View reviewed changes

NaturezzZ requested a review from yihong0618 November 24, 2024 05:55

yihong0618 approved these changes Nov 24, 2024

View reviewed changes

yihong0618 merged commit fb4290a into yihong0618:master Nov 24, 2024
6 checks passed

NaturezzZ deleted the better-activity-name branch November 24, 2024 07:52

ben-29 mentioned this pull request Nov 28, 2024

为什么的运动记录有地点标题，我的只有Run from codoon ben-29/workouts_page#37

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Richer activity title with more sport types and locations #733

Richer activity title with more sport types and locations #733

NaturezzZ commented Nov 10, 2024

vercel bot commented Nov 10, 2024 •

edited

Loading

yihong0618 left a comment

NaturezzZ commented Nov 11, 2024

yihong0618 commented Nov 11, 2024

ben-29 left a comment

ben-29 Nov 18, 2024

ben-29 Nov 18, 2024

NaturezzZ Nov 21, 2024

NaturezzZ Nov 21, 2024

NaturezzZ Nov 21, 2024

ben-29 Nov 18, 2024

NaturezzZ Nov 21, 2024

ben-29 Nov 18, 2024

NaturezzZ Nov 21, 2024

ben-29 Nov 18, 2024

NaturezzZ commented Nov 18, 2024

NaturezzZ commented Nov 21, 2024

ben-29 left a comment

ben-29 Nov 22, 2024

NaturezzZ commented Nov 22, 2024

yihong0618 left a comment

yihong0618 commented Nov 24, 2024

yihong0618 commented Nov 25, 2024

NaturezzZ commented Nov 25, 2024

yihong0618 commented Nov 25, 2024

		@@ -135,10 +148,37 @@ def update_or_create_activity(session, run_activity):
		return created


		def add_missing_columns(engine, model):

Richer activity title with more sport types and locations #733

Richer activity title with more sport types and locations #733

Conversation

NaturezzZ commented Nov 10, 2024

vercel bot commented Nov 10, 2024 • edited Loading

yihong0618 left a comment

Choose a reason for hiding this comment

NaturezzZ commented Nov 11, 2024

yihong0618 commented Nov 11, 2024

ben-29 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NaturezzZ commented Nov 18, 2024

NaturezzZ commented Nov 21, 2024

ben-29 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NaturezzZ commented Nov 22, 2024

yihong0618 left a comment

Choose a reason for hiding this comment

yihong0618 commented Nov 24, 2024

yihong0618 commented Nov 25, 2024

NaturezzZ commented Nov 25, 2024

yihong0618 commented Nov 25, 2024

vercel bot commented Nov 10, 2024 •

edited

Loading