Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: subtype issue #744

Merged
merged 2 commits into from
Nov 25, 2024
Merged

fix: subtype issue #744

merged 2 commits into from
Nov 25, 2024

Conversation

yihong0618
Copy link
Owner

maybe

Signed-off-by: yihong0618 <[email protected]>
Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
running-page ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 1:46pm

@NaturezzZ
Copy link
Collaborator

The default subtype is 'generic'.

@yihong0618
Copy link
Owner Author

The default subtype is 'generic'.

The default subtype is 'generic'.

yes there's a nametuple in

def sync_from_app(self, app_tracks):...... created = update_or_create_activity(self.session, t)

can reproduce local and fixed
image

Signed-off-by: yihong0618 <[email protected]>
@yihong0618
Copy link
Owner Author

we can change them to dataclass later, let's quick merge this first

@yihong0618 yihong0618 merged commit 23f5824 into master Nov 25, 2024
10 checks passed
@yihong0618 yihong0618 deleted the fix_subtype_from_app branch November 25, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants