-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #71: Deprecate CsrfMiddleware
in favor of CsrfTokenMiddleware
#71
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #71 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 47 61 +14
===========================================
Files 8 9 +1
Lines 128 166 +38
===========================================
+ Hits 128 166 +38 ☔ View full report in Codecov by Sentry. |
82339ad
to
32894f7
Compare
I just copy/paste existing code, but I can add missing tests if needed |
@ev-gor deprecated class could be excluded from testing. |
0945101
to
decf6f6
Compare
Why? It's reduced code coverage. I suggest removing tests for deprecate classes at the time of their deletion. |
Alright. @vjik suggestion makes sense. |
7d98cac
to
c22652a
Compare
OK, I added tests for the new class and left tests for the deprecated one but with prefix 'Deprecated' in their names to make it easier to remove them in the future. |
CsrfMiddleware
in favor of CsrfTokenMiddleware
Thank you! |
Fix #70