Fix #175: Add testcase for multibyte LikeHandler (#190)

* Fix #175: Add testcase for multibyte LikeHandler * Do not ignore mutants * Use str_contains for case sensitive search * Add CHANGELOG * Update CHANGELOG.md Co-authored-by: Sergei Predvoditelev <[email protected]> --------- Co-authored-by: Alexey Rogachev <[email protected]> Co-authored-by: Sergei Predvoditelev <[email protected]>
yiisoft · Sep 8, 2024 · 5f7cc68 · 5f7cc68
1 parent 9c31209
commit 5f7cc68
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -28,6 +28,7 @@
 - New #173, #184: Add `$caseSensitive` parameter to `Like` filter to control whether the search must be case-sensitive
   or not (@arogachev)
 - Chg #163: Rename `FilterableDataInterface::withFilterHandlers()` to `FilterableDataInterface::withAddedFilterHandlers()` (@samdark)
+- Enh #190: Use `str_contains` for case-sensitive match in `LikeHandler` (@samdark)
 
 ## 1.0.1 January 25, 2023
 

diff --git a/src/Reader/Iterable/FilterHandler/LikeHandler.php b/src/Reader/Iterable/FilterHandler/LikeHandler.php
@@ -30,9 +30,8 @@ public function match(object|array $item, FilterInterface $filter, array $iterab
             return false;
         }
 
-        /** @infection-ignore-all MBString No suitable test case was found yet. */
         return $filter->isCaseSensitive() === true
-            ? mb_strpos($itemValue, $filter->getValue()) !== false
+            ? str_contains($itemValue, $filter->getValue())
             : mb_stripos($itemValue, $filter->getValue()) !== false;
     }
 }
diff --git a/tests/Reader/Iterable/FilterHandler/LikeHandlerTest.php b/tests/Reader/Iterable/FilterHandler/LikeHandlerTest.php
@@ -34,6 +34,8 @@ public static function matchDataProvider(): array
             [false, ['id' => 1, 'value' => 'Great Cat Fighter'], 'id', '1', true],
             [true, ['id' => 1, 'value' => '🙁🙂🙁'], 'value', '🙂', true],
             [true, ['id' => 1, 'value' => 'Привет мир'], 'value', ' ', true],
+
+            [true, ['id' => 1, 'value' => 'das Öl'], 'value', 'öl', false],
         ];
     }