Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Sergei Predvoditelev <[email protected]>
  • Loading branch information
Tigrov and vjik authored Dec 14, 2024
1 parent 252c041 commit 238dafe
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

- Enh #274: Refactor for compatibility with `yiisoft/db` package (@Tigrov)
- Bug #277: Fix when there is a namespace but the directory does not exist (@Tigrov)
- Enh #279: Use `ColumnBuilder` class to create table column definitions (@Tigrov)
- Chg #279: Use `ColumnBuilder` class to create table column definitions (@Tigrov)

## 1.2.0 November 27, 2024

Expand Down
2 changes: 0 additions & 2 deletions src/Migrator.php
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,6 @@ private function createMigrationHistoryTable(): void
$tableName = $this->db->getQuoter()->getRawTableName($this->historyTable);
$this->informer->beginCreateHistoryTable('Creating migration history table "' . $tableName . '"...');

$b = $this->createBuilder(new NullMigrationInformer());

$b->createTable($this->historyTable, [

Check failure on line 151 in src/Migrator.php

View workflow job for this annotation

GitHub Actions / PHP 8.2

UndefinedVariable

src/Migrator.php:151:9: UndefinedVariable: Cannot find referenced variable $b (see https://psalm.dev/024)

Check failure on line 151 in src/Migrator.php

View workflow job for this annotation

GitHub Actions / PHP 8.2

MixedMethodCall

src/Migrator.php:151:13: MixedMethodCall: Cannot determine the type of $b when calling method createTable (see https://psalm.dev/015)

Check failure on line 151 in src/Migrator.php

View workflow job for this annotation

GitHub Actions / PHP 8.3

UndefinedVariable

src/Migrator.php:151:9: UndefinedVariable: Cannot find referenced variable $b (see https://psalm.dev/024)

Check failure on line 151 in src/Migrator.php

View workflow job for this annotation

GitHub Actions / PHP 8.3

MixedMethodCall

src/Migrator.php:151:13: MixedMethodCall: Cannot determine the type of $b when calling method createTable (see https://psalm.dev/015)

Check failure on line 151 in src/Migrator.php

View workflow job for this annotation

GitHub Actions / PHP 8.1

UndefinedVariable

src/Migrator.php:151:9: UndefinedVariable: Cannot find referenced variable $b (see https://psalm.dev/024)

Check failure on line 151 in src/Migrator.php

View workflow job for this annotation

GitHub Actions / PHP 8.1

MixedMethodCall

src/Migrator.php:151:13: MixedMethodCall: Cannot determine the type of $b when calling method createTable (see https://psalm.dev/015)
'id' => ColumnBuilder::primaryKey(),
'name' => ColumnBuilder::string($this->migrationNameLimit)->notNull(),
Expand Down

0 comments on commit 238dafe

Please sign in to comment.