Remove yiisoft/definitions dependency
#206
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #206 +/- ##
=========================================
Coverage 99.78% 99.78%
Complexity 268 268
=========================================
Files 19 19
Lines 912 912
=========================================
Hits 910 910
Misses 2 2 ☔ View full report in Codecov by Sentry. |
vjik
requested changes
Oct 14, 2023
| @@ -27,7 +27,6 @@ | |||
| "yiisoft/aliases": "^1.1|^2.0|^3.0", | |||
| "yiisoft/db": "^1.1", | |||
| "yiisoft/di": "^1.0", | |||
| "yiisoft/definitions": "^3.0", | |||
There was a problem hiding this comment.
This package used in MigrationContainer
|
Closed due to comment #206 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not used in the package directly but used in
yiisoft/dipackage which already has the dependency