Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow use maxSqlOutputLength #211

Merged
merged 11 commits into from
Oct 16, 2023
Merged

Allow use maxSqlOutputLength #211

merged 11 commits into from
Oct 16, 2023

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Oct 15, 2023 •
edited
Loading

Q A
Is bugfix? ❌
New feature? ❌
Breaks BC? ❌
Fixed issues #205, #214

@codecov
Copy link

codecov bot commented Oct 15, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (0e23a9f) 99.78% compared to head (cb928a1) 99.78%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #211      +/-   ##
============================================
- Coverage     99.78%   99.78%   -0.01%     
  Complexity      277      277              
============================================
  Files            19       19              
  Lines           938      936       -2     
============================================
- Hits            936      934       -2     
  Misses            2        2
Files Coverage Δ
src/MigrationBuilder.php 100.00% <100.00%> (ø)
src/Migrator.php 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov marked this pull request as ready for review October 15, 2023 07:31
vjik
vjik requested changes Oct 15, 2023
View reviewed changes
src/Migrator.php Outdated Show resolved Hide resolved
tests/Common/AbstractMigratorTest.php Outdated Show resolved Hide resolved
src/Migrator.php Outdated Show resolved Hide resolved
vjik
vjik reviewed Oct 16, 2023
View reviewed changes
bin/MigrationContainer.php Outdated Show resolved Hide resolved
@vjik vjik merged commit 59f8546 into master Oct 16, 2023
75 of 76 checks passed
@vjik vjik deleted the allow_use_maxSqlOutputLength branch October 16, 2023 07:58
This was referenced Oct 16, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vjik vjik vjik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tigrov @vjik @StyleCIBot