Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output rawSql() for execute() method #230

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Nov 4, 2023

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

Copy link

what-the-diff bot commented Nov 4, 2023

PR Summary

  • Simplified Database Queries in src/MigrationBuilder.php
    The code in this file has been optimized to make it simpler and more efficient to execute SQL statements in the database. A more streamlined approach has been adopted, using the bindValues and getRawSql methods. This increases the readability and maintainability of the code.

  • Improved Testing in tests/Common/AbstractMigrationBuilderTest.php
    The mechanism for performing database tests has been updated. A more explicit declaration of SQL query strings has been included, while the manner in which these queries are executed has been improved. These changes take into consideration the changes made in the src/MigrationBuilder.php as well. The updated assertion also gives a clearer test feedback by including the SQL query string outcome in the assertion message. This ensures our tests are more robust and reliable.

  • No Significant Changes to tests/Support/Migrations/M231015155500ExecuteSql.php
    There appears to be no important changes made in this file as no discernible difference is seen in this part of the PR.

Copy link

codecov bot commented Nov 4, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (2ef6724) 99.79% compared to head (83f0445) 0.00%.

❗ Current head 83f0445 differs from pull request most recent head 7dc0830. Consider uploading reports for the commit 7dc0830 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #230       +/-   ##
============================================
- Coverage     99.79%   0.00%   -99.80%     
  Complexity      290     290               
============================================
  Files            19      19               
  Lines           960     961        +1     
============================================
- Hits            958       0      -958     
- Misses            2     961      +959     
Files Coverage Δ
src/MigrationBuilder.php 0.00% <0.00%> (-100.00%) ⬇️

... and 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov marked this pull request as ready for review November 4, 2023 04:57
@Tigrov Tigrov requested a review from a team November 7, 2023 10:39
@Tigrov Tigrov added the status:code review The pull request needs review. label Nov 7, 2023
@Tigrov Tigrov merged commit d227ecd into master Nov 7, 2023
1 check passed
@Tigrov Tigrov deleted the output-rawsql-for-execute branch November 7, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants