Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Oracle tests running locally #232

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Fix Oracle tests running locally #232

merged 1 commit into from
Nov 10, 2023

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Nov 9, 2023

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

Copy link

what-the-diff bot commented Nov 9, 2023

PR Summary

  • Database Connection Update in OracleFactory.php
    The database we connect to in our software has been updated. Before, we were connecting to a different database. Now, our software directly connects to a database named localhost:1521/XE.

  • Modification to Table Deletion Method
    Previously, our software deleted tables with the dropTable method, which sometimes left behind unwanted data or constraints connected to the table. The change made ensures that all related elements to that table are destroyed, making it a complete and clean removal of the table. This avoids clutter and potential errors in the future.

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5f8b93d) 99.80% compared to head (336477f) 99.80%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #232   +/-   ##
=========================================
  Coverage     99.80%   99.80%           
  Complexity      309      309           
=========================================
  Files            19       19           
  Lines          1014     1014           
=========================================
  Hits           1012     1012           
  Misses            2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov marked this pull request as ready for review November 9, 2023 02:33
Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why GitHub Actions work without this changes, but don't work locally?

@Tigrov
Copy link
Member Author

Tigrov commented Nov 10, 2023

Why GitHub Actions work without this changes, but don't work locally?

  1. I have locally Oracle Database 21c XE (Express Edition)
    This does not work if not specify DB service name XE
    'oci:dbname=localhost:1521/XE;charset=AL32UTF8',

  2. In some cases during development there were problems with dependent CONSTRAINTS when dropping tables.
    Now it works without changes, but in the future may encounter the same problem.
    GitHub Actions always have clear DB, but locally it could has old objects, e.g. after an exception.

@vjik vjik merged commit a9bfbf0 into master Nov 10, 2023
76 checks passed
@vjik vjik deleted the fix-oracle-tests-on-locale branch November 10, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants