Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactoring and cleanup #237

Merged
merged 8 commits into from
Nov 26, 2023
Merged

Minor refactoring and cleanup #237

merged 8 commits into from
Nov 26, 2023

Conversation

vjik
Copy link
Member

@vjik vjik commented Nov 24, 2023

Q A
Is bugfix?
New feature?
Breaks BC? ✔️
Fixed issues -

Copy link

what-the-diff bot commented Nov 24, 2023

PR Summary

  • Enhanced Security in Workflow Configuration
    Added a section for secrets in the workflow configuration, which includes a parameter for a token. This helps to maintain the integrity and security of your application.

  • Cleaned the Installation Guide
    Removed unneeded flags from the installation command in the README file. This simplifies the installation process.

  • Standardized Naming Convention
    The setIO method has been renamed to setIo across multiple files. This makes the codebase more consistent, helping developers to better understand and maintain it.

  • Updated PHP Version
    The PHP version used in the workflow has been updated from 8.0 to 8.2. This ensures compatibility with newer libraries and helps leverage the latest features.

  • Refactored Database Migration Logic
    The trim function calls have been removed from a few methods in the migrationBuilder class. Further, if not provided, the io parameter of the migrationService class is now defaulted to null.

  • Removed Unnecessary Annotations
    Unneeded @psalm-var and @psalm-suppress annotations have been removed from various files.

  • Updated Test Cases
    Test methods in various classes have been updated to expect the correct exception message. This improves test reliability and accuracy.

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e8ad9e3) 100.00% compared to head (788e8de) 100.00%.

❗ Current head 788e8de differs from pull request most recent head 1e040d6. Consider uploading reports for the commit 1e040d6 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #237   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       313       313           
===========================================
  Files             19        19           
  Lines           1027      1027           
===========================================
  Hits            1027      1027           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik added the status:code review The pull request needs review. label Nov 24, 2023
@vjik vjik requested a review from a team November 24, 2023 08:28
@vjik vjik added this to the 1.0.0 milestone Nov 24, 2023
src/MigrationBuilder.php Outdated Show resolved Hide resolved
@vjik vjik merged commit 3a29b7d into master Nov 26, 2023
75 of 77 checks passed
@vjik vjik deleted the improve branch November 26, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants