Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #227 #250

Merged
merged 7 commits into from
Dec 23, 2023
Merged

Fix #227 #250

merged 7 commits into from
Dec 23, 2023

Conversation

viktorprogger
Copy link
Contributor

Q A
Is bugfix?
New feature?
Breaks BC? #227

@viktorprogger viktorprogger requested a review from a team December 21, 2023 17:23
Copy link

what-the-diff bot commented Dec 21, 2023

PR Summary

  • Improved Database Integration
    The team added a set of new methods in the AbstractMigrationBuilder.php file, aiming to enhance the way we interact with different types of databases.

  • Added bigPrimaryKeyUnsigned(), uuidPrimaryKey(), and primaryKeyUnsigned() methods
    These methods allow creating different types of primary key columns. Specifically, these keys can be of 'big unsigned' variety for operations demanding larger key sizes, or 'UUID' format for scenarios requiring unique identifiers.

  • Introduced uuidPrimaryKeySequenced() Method
    This method is an extension to the basic UUID primary key creation. It allows creating primary keys that have an associated sequence. This can be beneficial in scenarios where we need to manage unique keys that also represent a particular order.

  • Implemented uuid() Method
    An additional method for creating UUID type column was added for diversifying the ways we manage unique data items in our database.

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2255209) 100.00% compared to head (9701f9e) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #250   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       312       315    +3     
===========================================
  Files             21        21           
  Lines           1050      1056    +6     
===========================================
+ Hits            1050      1056    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need tests and line in changelog

@samdark samdark added pr:request for unit tests Unit tests are needed. type:enhancement Enhancement labels Dec 22, 2023
@samdark samdark added this to the 1.0.1 milestone Dec 22, 2023
@samdark samdark removed the pr:request for unit tests Unit tests are needed. label Dec 23, 2023
@viktorprogger viktorprogger modified the milestones: 1.0.1, 1.1.0 Dec 23, 2023
@viktorprogger viktorprogger added the status:code review The pull request needs review. label Dec 23, 2023
@samdark samdark merged commit 3ce36f3 into master Dec 23, 2023
104 checks passed
@samdark samdark deleted the more-column-shortcats branch December 23, 2023 18:38
@samdark
Copy link
Member

samdark commented Dec 23, 2023

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review. type:enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants