Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use Yii DB deprecated methods in Migrator #268

Merged
merged 6 commits into from
Jul 12, 2024
Merged

Don't use Yii DB deprecated methods in Migrator #268

merged 6 commits into from
Jul 12, 2024

Conversation

vjik
Copy link
Member

@vjik vjik commented Jul 11, 2024

Q A
Is bugfix?
New feature?
Breaks BC?

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.90%. Comparing base (cac68ec) to head (37a466b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##              master     #268      +/-   ##
=============================================
- Coverage     100.00%   99.90%   -0.10%     
  Complexity       315      315              
=============================================
  Files             21       21              
  Lines           1056     1056              
=============================================
- Hits            1056     1055       -1     
- Misses             0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik changed the title Fix psalm Don't use Yii DB deprecated methods in Migrator Jul 11, 2024
@vjik vjik requested a review from a team July 11, 2024 08:07
@vjik vjik added the status:code review The pull request needs review. label Jul 11, 2024
@samdark samdark merged commit 192577d into master Jul 12, 2024
103 of 104 checks passed
@samdark samdark deleted the fix-psalm branch July 12, 2024 05:46
@samdark
Copy link
Member

samdark commented Jul 12, 2024

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants