Use new column builder #279
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #279 +/- ##
============================================
- Coverage 99.71% 96.08% -3.64%
+ Complexity 316 313 -3
============================================
Files 21 21
Lines 1058 1047 -11
============================================
- Hits 1055 1006 -49
- Misses 3 41 +38 ☔ View full report in Codecov by Sentry. |
samdark
approved these changes
Dec 6, 2024
vjik
reviewed
Dec 13, 2024
CHANGELOG.md
Outdated
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| - Enh #274: Refactor for compatibility with `yiisoft/db` package (@Tigrov) | |||
| - Bug #277: Fix when there is a namespace but the directory does not exist (@Tigrov) | |||
| - Enh #279: Use `ColumnBuilder` class to create table column definitions (@Tigrov) | |||
There was a problem hiding this comment.
Suggested change
| - Enh #279: Use `ColumnBuilder` class to create table column definitions (@Tigrov) | |
| - Chg #279: Use `ColumnBuilder` class to create table column definitions (@Tigrov) |
Seems, this is BC-break changes
There was a problem hiding this comment.
Seems, this is BC-break changes
Yes, changes of AbstractMigrationBuilder make the BC.
Co-authored-by: Sergei Predvoditelev <[email protected]>
vjik
approved these changes
Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR