-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test cases typo fixed & missing PHPDocs added. #324
Conversation
MrWasimAbbasi
commented
Mar 31, 2024
•
edited
Loading
edited
Q | A |
---|---|
Is bugfix? | ❌ |
New feature? | ❌ |
Breaks BC? | ❌ |
Fixed issues | Typo fixes and missing PHPDoc added |
PR Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #324 +/- ##
=========================================
Coverage 99.04% 99.04%
Complexity 174 174
=========================================
Files 13 13
Lines 524 524
=========================================
Hits 519 519
Misses 5 5 ☔ View full report in Codecov by Sentry. |
Thanks for the PR, but the changes do not seem to make sense. See https://github.com/yiisoft/docs/blob/master/010-code-style.md#comments Method comment is necessary except it adds nothing to what method name and signature already has. |
It's make sense for exceptions, that need to catch in code, that usage it method. |
Then when possible and reasonably it is better to add them to interfaces. |
@@ -51,6 +51,9 @@ protected function buildCommentString(): string | |||
return ' COMMENT ' . (string) (new Quoter('`', '`'))->quoteValue($this->getComment()); | |||
} | |||
|
|||
/** | |||
* @return string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed since it's obvious from return type and there's no custom description.
Closing since we're not going to apply the pull request. Thanks for submitting it anyway. |