Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change $typeMap to constant #324

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Change $typeMap to constant #324

merged 3 commits into from
Nov 16, 2023

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Nov 16, 2023

The change will reduce size of cache.

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

Copy link

what-the-diff bot commented Nov 16, 2023

PR Summary

  • Modification of "Schema.php" File
    The file "Schema.php" has gone through some changes to improve its functionality.

  • Property Renaming and Redefinition
    The previously named typeMap property has now been renamed to TYPE_MAP. Moreover, its nature has been changed from a private instance property to a private constant. This alteration will make the code cleaner and easier to understand.

  • URL Update in PHPDoc Annotation
    The URL provided in the @link annotation within the PHPDoc has been updated to maintain correspondence with the authoritative PostgreSQL documentation.

  • Expression Replacement
    A particular expression has been replaced to make it more readable and to ensure the ‘column type’ data utilizes the newly defined TYPE_MAP constant.

  • Method Update
    The type() method has been updated, now using the TYPE_MAP constant to set the 'column type'. This update streamlines the process of managing column types.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (743a684) 100.00% compared to head (a8579fd) 100.00%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #324   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       187       187           
===========================================
  Files             13        13           
  Lines            566       566           
===========================================
  Hits             566       566           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov added the status:code review The pull request needs review. label Nov 16, 2023
@vjik vjik merged commit 80445f0 into master Nov 16, 2023
32 of 33 checks passed
@vjik vjik deleted the change-typemap-to-constant branch November 16, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants