Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix table indexes #331

Merged
merged 6 commits into from
Jan 16, 2024
Merged

Fix table indexes #331

merged 6 commits into from
Jan 16, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Jan 10, 2024

Do not include in index column names fields specified in INCLUDE clause.

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues -

Copy link

what-the-diff bot commented Jan 10, 2024

PR Summary

  • Enhancement in Schema.php
    The Schema.php file now contains a refinement to the INNER JOIN operation within the loadTableIndexes function. This enhancement ensures that the process becomes more selective, thus improving its efficiency.

  • New Test Addition in SchemaTest.php
    A new test method named testTableIndexes has been added to the SchemaTest.php file. This test allows us to better verify the operation of table indexes, improving the reliability of the database performance.

  • Addition of pgsql11.sql
    A new SQL file named pgsql11.sql has been included in the tests/Support/Fixture directory. This file will assist with database testing and contribute to ensuring the credibility of the tests.

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (02a2a87) 100.00% compared to head (fd23bae) 100.00%.

❗ Current head fd23bae differs from pull request most recent head 38abc14. Consider uploading reports for the commit 38abc14 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #331   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       241       241           
===========================================
  Files             16        16           
  Lines            694       694           
===========================================
  Hits             694       694           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@darkdef darkdef requested a review from terabytesoftw January 13, 2024 18:10
@Tigrov Tigrov merged commit be590ac into yiisoft:master Jan 16, 2024
2 checks passed
@Tigrov Tigrov deleted the fix_table_index branch January 16, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants