Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor AbstractCommand::getRawSql() #785

Merged
merged 10 commits into from
Nov 26, 2023
Merged

Refactor AbstractCommand::getRawSql() #785

merged 10 commits into from
Nov 26, 2023

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Nov 26, 2023

  • Refactor AbstractCommand::getRawSql()
  • Fix bug when value is Stringable object
Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues #783

Copy link

what-the-diff bot commented Nov 26, 2023

PR Summary

  • Enhancements for Project Documentation
    The project's change log, which records all the major updates and improvements, was updated.

  • Updates to the Core Functionalities
    Made several improvements to a 'command' section of our codebase that is used for executing various operations. This includes removing unnecessary or obsolete parts of the code and introducing a new way to deal with different types of input parameters.

  • Bug Fixes
    Addressed a problem in our 'command' section where the system was not correctly handling instances where a parameter was a certain type of data (specifically a 'Stringable' object).

  • Added Test Support
    In order to check the effectiveness of these changes, especially the fix related to 'Stringable' parameters, a new test support file was introduced. This will help ensure our system works as expected when handling various forms of data inputs.

Copy link

codecov bot commented Nov 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f06cf26) 99.64% compared to head (5d7dd21) 99.64%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #785   +/-   ##
=========================================
  Coverage     99.64%   99.64%           
+ Complexity     1271     1264    -7     
=========================================
  Files            63       63           
  Lines          3058     3062    +4     
=========================================
+ Hits           3047     3051    +4     
  Misses           11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik merged commit c4c4a9d into master Nov 26, 2023
167 of 168 checks passed
@vjik vjik deleted the refactor-geRawSql branch November 26, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants