Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method chaining for columns #852

Merged
merged 7 commits into from
Jun 23, 2024
Merged

Add method chaining for columns #852

merged 7 commits into from
Jun 23, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented May 30, 2024

Preparing to combine Column and ColumnSchema in one class

Related PR

Q A
Is bugfix?
New feature? ✔️/❌
Breaks BC?
Fixed issues #854

Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.72%. Comparing base (61c325e) to head (ff9c0f8).

Current head ff9c0f8 differs from pull request most recent head f3d9636

Please upload reports for the commit f3d9636 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #852      +/-   ##
============================================
+ Coverage     99.66%   99.72%   +0.06%     
  Complexity     1348     1348              
============================================
  Files            71       71              
  Lines          3306     3322      +16     
============================================
+ Hits           3295     3313      +18     
+ Misses           11        9       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov added the status:code review The pull request needs review. label Jun 22, 2024
@Tigrov Tigrov requested a review from a team June 22, 2024 04:25
Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add info to changelog and upgrade

@Tigrov Tigrov merged commit 032642e into master Jun 23, 2024
2 checks passed
@Tigrov Tigrov deleted the add-method-chaining branch June 23, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants