Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse comment from column definition #914

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Jan 6, 2025

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues #854

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.53%. Comparing base (4f9a12a) to head (ddb979c).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #914   +/-   ##
=========================================
  Coverage     99.53%   99.53%           
- Complexity     1550     1551    +1     
=========================================
  Files            82       82           
  Lines          3834     3837    +3     
=========================================
+ Hits           3816     3819    +3     
  Misses           18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov added the status:code review The pull request needs review. label Jan 6, 2025
@Tigrov Tigrov requested a review from a team January 6, 2025 11:28
@Tigrov Tigrov merged commit 209c594 into master Jan 7, 2025
3 checks passed
@Tigrov Tigrov deleted the parse-comment-from-columndefinition branch January 7, 2025 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants