Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple method call in array definition #90

Merged
merged 5 commits into from
Mar 10, 2024
Merged

Allow multiple method call in array definition #90

merged 5 commits into from
Mar 10, 2024

Conversation

vjik
Copy link
Member

@vjik vjik commented Mar 10, 2024

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Fixed issues

Copy link

what-the-diff bot commented Mar 10, 2024

PR Summary

  • New Feature in Definition Validator
    A new capability was added that allows for the execution of multiple method calls while defining arrays. This change should provide enhanced flexibility and efficiency in operations involving complex array definitions.
  • New Feature Testing
    To verify the proper functioning of this new feature, we've added respective new test cases. This will help ensure that the new feature works exactly as expected and does not introduce any undesired behaviors.
  • Validation Test for Multiple Call Methods
    Along with the feature testing, a specific validation test has also been introduced for checking multiple call methods. This will ensure the array definitions involving multiple call methods are always validated correctly.

Copy link

codecov bot commented Mar 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (bd5a96e) to head (707759f).

Additional details and impacted files
@@             Coverage Diff             @@
##              master       #90   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       242       243    +1     
===========================================
  Files             16        16           
  Lines            653       652    -1     
===========================================
- Hits             653       652    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik merged commit c5c9d0a into master Mar 10, 2024
24 checks passed
@vjik vjik deleted the multicall branch March 10, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants