Add error code & show function arguments

CHANGELOG.md

@@ -1,7 +1,8 @@
 # Yii Error Handler Change Log
 
-## 3.3.1 under development
+## 3.4.0 under development
 
+- Enh #125: Add error code & show function arguments (@xepozz)
 - Enh #130: Pass exception message instead of rendered exception to logger in `ErrorHandler` (@olegbaturin)
 - Enh #133: Extract response generator from `ErrorCatcher` middleware into separate `ThrowableResponseFactory` class (@olegbaturin)
 

src/ErrorHandler.php

@@ -50,7 +50,7 @@
         private LoggerInterface $logger,
         private ThrowableRendererInterface $defaultRenderer,
         private ?EventDispatcherInterface $eventDispatcher = null,
         private int $exitShutdownHandlerDepth = 2
     ) {
     }
 
@@ -68,7 +68,7 @@
         $renderer ??= $this->defaultRenderer;
 
         try {
             $this->logger->error($t->getMessage(), ['throwable' => $t]);
             return $this->debug ? $renderer->renderVerbose($t, $request) : $renderer->render($t, $request);
         } catch (Throwable $t) {
             return new ErrorData((string) $t);
@@ -108,14 +108,14 @@
             return;
         }
 
         if ($this->memoryReserveSize > 0) {
             $this->memoryReserve = str_repeat('x', $this->memoryReserveSize);
         }
 
         $this->initializeOnce();
 
         // Handles throwable that isn't caught otherwise, echo output and exit.
         set_exception_handler(function (Throwable $t): void {
             if (!$this->enabled) {
                 return;
             }
@@ -126,15 +126,16 @@
         // Handles PHP execution errors such as warnings and notices.
         set_error_handler(function (int $severity, string $message, string $file, int $line): bool {
             if (!$this->enabled) {
                 return false;
             }
 
             if (!(error_reporting() & $severity)) {
                 // This error code is not included in error_reporting.
                 return true;
             }
 
-            $backtrace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS);
+            $backtrace = debug_backtrace(0);
+            array_shift($backtrace);
             throw new ErrorException($message, $severity, $severity, $file, $line, null, $backtrace);
         });
 

src/Renderer/HtmlRenderer.php

@@ -256,22 +256,34 @@ public function renderCallStack(Throwable $t, array $trace = []): string
             [],
         );
 
-        $length = count($trace);
-        for ($i = 0; $i < $length; ++$i) {
-            $file = !empty($trace[$i]['file']) ? $trace[$i]['file'] : null;
-            $line = !empty($trace[$i]['line']) ? $trace[$i]['line'] : null;
-            $class = !empty($trace[$i]['class']) ? $trace[$i]['class'] : null;
-            $args = !empty($trace[$i]['args']) ? $trace[$i]['args'] : [];
+        $index = 1;
+        if ($t instanceof ErrorException) {
+            $index = 0;
+        }
+
+        foreach ($trace as $traceItem) {
+            $file = !empty($traceItem['file']) ? $traceItem['file'] : null;
+            $line = !empty($traceItem['line']) ? $traceItem['line'] : null;
+            $class = !empty($traceItem['class']) ? $traceItem['class'] : null;
+            $args = !empty($traceItem['args']) ? $traceItem['args'] : [];
 
             $parameters = [];
             $function = null;
-            if (!empty($trace[$i]['function']) && $trace[$i]['function'] !== 'unknown') {
-                $function = $trace[$i]['function'];
-                if ($class !== null && !str_contains($function, '{closure}')) {
-                    $parameters = (new \ReflectionMethod($class, $function))->getParameters();
+            if (!empty($traceItem['function']) && $traceItem['function'] !== 'unknown') {
+                $function = $traceItem['function'];
+                if (!str_contains($function, '{closure}')) {
+                    try {
+                        if ($class !== null && class_exists($class)) {
+                            $parameters = (new \ReflectionMethod($class, $function))->getParameters();
+                        } elseif (function_exists($function)) {
+                            $parameters = (new \ReflectionFunction($function))->getParameters();
+                        }
+                    } catch (\ReflectionException) {
+                        // pass
+                    }
                 }
             }
-            $index = $i + 2;
+            $index++;
 
             if ($this->isVendorFile($file)) {
                 $vendor[$index] = $this->renderCallStackItem(
@@ -588,7 +600,7 @@ private function groupVendorCallStackItems(array $items): array
             $groupedItems[$groupIndex][$index] = $item;
         }
 
-        /** @psalm-var array<int, array<int, string>> $groupedItems It's need for Psalm <=4.30 only. */
+        /** @psalm-var array<int, array<int, string>> $groupedItems It's needed for Psalm <=4.30 only. */
 
         return $groupedItems;
     }

templates/development.php

@@ -73,6 +73,7 @@
             <?php else: ?>
                 <span><?= $exceptionClass ?></span>
             <?php endif ?>
+            (Code #<?= $throwable->getCode() ?>)
         </div>
 
         <div class="exception-message">