Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add solution providers #127

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Add solution providers #127

wants to merge 10 commits into from

Conversation

xepozz
Copy link
Member

@xepozz xepozz commented Jul 18, 2024

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Fixed issues #108

@vjik vjik added the status:under development Someone is working on a pull request. label Jul 22, 2024
@vjik
Copy link
Member

vjik commented Aug 5, 2024

Looks cool! But I suggest do it in separate package.

@xepozz
Copy link
Member Author

xepozz commented Oct 14, 2024

Looks cool! But I suggest do it in separate package.

All the rest implementation, but it's base support for all of them

@xepozz xepozz self-assigned this Oct 14, 2024
@xepozz xepozz changed the title [WIP] Add solution providers Add solution providers Dec 21, 2024
@samdark
Copy link
Member

samdark commented Dec 21, 2024

@xepozz what's missing here?

@xepozz
Copy link
Member Author

xepozz commented Dec 22, 2024

I think I lost some files in the original codebase, some of them already moved to bridge for error handling 😁

@samdark
Copy link
Member

samdark commented Dec 23, 2024

Possible to update it?

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 52.63158% with 9 lines in your changes missing coverage. Please review.

Project coverage is 76.43%. Comparing base (16a53fd) to head (b5e5ddf).

Files with missing lines Patch % Lines
src/Solution/FriendlyExceptionSolution.php 0.00% 4 Missing ⚠️
src/Renderer/HtmlRenderer.php 57.14% 3 Missing ⚠️
src/Solution/SolutionGenerator.php 75.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #127      +/-   ##
============================================
- Coverage     77.08%   76.43%   -0.66%     
- Complexity      184      191       +7     
============================================
  Files            14       16       +2     
  Lines           576      594      +18     
============================================
+ Hits            444      454      +10     
- Misses          132      140       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:under development Someone is working on a pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants