Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trace for error #96

Merged
merged 16 commits into from
Jan 30, 2024
Merged

Trace for error #96

merged 16 commits into from
Jan 30, 2024

Conversation

xepozz
Copy link
Member

@xepozz xepozz commented Jan 14, 2024

Q A
Is bugfix? ✔️
New feature? ❌
Breaks BC? ❌
image

VS

image

@codecov Codecov
Copy link

codecov bot commented Jan 14, 2024 •
edited
Loading

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (3882b7b) 80.12% compared to head (57ca518) 78.66%.

Files Patch % Lines
src/ErrorHandler.php 16.66% 10 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master      #96      +/-   ##
============================================
- Coverage     80.12%   78.66%   -1.46%     
- Complexity      169      170       +1     
============================================
  Files            13       13              
  Lines           498      511      +13     
============================================
+ Hits            399      402       +3     
- Misses           99      109      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

samdark
samdark approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Would you please add a line for CHANGELOG and probably fix issues highlighed by CI run?

vjik
vjik reviewed Jan 20, 2024
View reviewed changes
@vjik vjik requested a review from a team January 30, 2024 13:02
@vjik vjik added the status:code review The pull request needs review. label Jan 30, 2024
@vjik vjik merged commit f8641c3 into master Jan 30, 2024
30 of 32 checks passed
@vjik vjik deleted the trace-for-error branch January 30, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vjik vjik vjik left review comments

@samdark samdark samdark approved these changes

Assignees
No one assigned
Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xepozz @samdark @vjik @StyleCIBot