Reset validation result #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KovYu
commented
May 20, 2024
KovYu
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ✔️ |
| Breaks BC? | ❌ |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22 +/- ##
=============================================
- Coverage 100.00% 96.07% -3.93%
- Complexity 20 21 +1
=============================================
Files 4 4
Lines 53 51 -2
=============================================
- Hits 53 49 -4
- Misses 0 2 +2 ☔ View full report in Codecov by Sentry. |
xepozz
requested changes
May 20, 2024
| @@ -32,4 +32,9 @@ public function getValidationResult(): Result | |||
|
|
|||
| return $this->validationResult; | |||
| } | |||
|
|
|||
| public function resetValidation(): void | |||
There was a problem hiding this comment.
Suggested change
| public function resetValidation(): void | |
| public function resetResult(): void |
There was a problem hiding this comment.
May be resetValidationResult() better?
vjik
requested changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.