First implementation #1
Conversation
vjik
commented
Apr 27, 2023
vjik
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ✔️ |
| Breaks BC? | ❌ |
| Fixed issues |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1 +/- ##
==========================================
Coverage ? 100.00%
Complexity ? 149
==========================================
Files ? 16
Lines ? 360
Branches ? 0
==========================================
Hits ? 360
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Alexey Rogachev <[email protected]>
Co-authored-by: Alexey Rogachev <[email protected]>
| ) { | ||
| return (string) $resolvedValue; | ||
| } | ||
| return ''; |
There was a problem hiding this comment.
Isn't it expected to become as an error?
There was a problem hiding this comment.
Idea of CastToString — cast value to string always.
There was a problem hiding this comment.
That it's better to handle it and add context: which attribute crashed the runtime
| true, | ||
| ); | ||
|
|
||
| $this->assertSame('.', $model->getA()); |
There was a problem hiding this comment.
Strict mode. In strcit mode hydrate properties from map only.
There was a problem hiding this comment.
I mean why the dot, but not an empty string, null or exception?
There was a problem hiding this comment.
In strict mode not hydrate properties which are not in map. In this test dots is default values in model:
There was a problem hiding this comment.
And what would happen if a model doesn't have default value?
…-implementation # Conflicts: # tests/Attribute/Parameter/ToStringTest.php
