Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for collections #90

Merged
merged 31 commits into from
Aug 7, 2024
Merged

Add support for collections #90

merged 31 commits into from
Aug 7, 2024

Conversation

arogachev
Copy link
Contributor

Q A
Is bugfix?
New feature? ✔️
Breaks BC? ✔️/❌

@arogachev arogachev self-assigned this Jul 29, 2024
@arogachev arogachev added the type:feature New feature label Jul 29, 2024
@arogachev arogachev linked an issue Aug 2, 2024 that may be closed by this pull request
@arogachev arogachev marked this pull request as ready for review August 2, 2024 09:26
@arogachev arogachev requested a review from a team August 2, 2024 09:28
@arogachev arogachev added the status:code review The pull request needs review. label Aug 2, 2024
@arogachev arogachev added this to the 1.3 milestone Aug 2, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
docs/guide/en/typecasting.md Outdated Show resolved Hide resolved
src/Attribute/Parameter/CollectionResolver.php Outdated Show resolved Hide resolved
docs/guide/en/typecasting.md Outdated Show resolved Hide resolved
src/AttributeHandling/ParameterAttributeResolveContext.php Outdated Show resolved Hide resolved
src/AttributeHandling/ParameterAttributesHandler.php Outdated Show resolved Hide resolved
src/AttributeHandling/ParameterAttributesHandler.php Outdated Show resolved Hide resolved
@arogachev arogachev requested review from a team and vjik August 5, 2024 08:37
src/AttributeHandling/ParameterAttributesHandler.php Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
tests/Attribute/Parameter/CollectionTest.php Outdated Show resolved Hide resolved
docs/guide/en/typecasting.md Outdated Show resolved Hide resolved
@arogachev arogachev requested review from a team and vjik August 5, 2024 11:51
### `Trim` / `LeftTrim` / `RightTrim`

To strip whitespace (or other characters) from the beginning and/or end of a resolved string value, you can use `Trim`,
`LeftTrim` or `RightTrim` attributes:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it better to name these TrimLeft/TrimRight?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your suggestion. I've created separate issue - #91, because it's out of scope of current PR.

@arogachev arogachev merged commit d7febf6 into master Aug 7, 2024
17 checks passed
@arogachev arogachev deleted the collection-support branch August 7, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review. type:feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for collections
4 participants