improve

yiisoft · Sep 14, 2023 · 327364e · 327364e
1 parent f7d7c4e
commit 327364e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/rector.php b/rector.php
@@ -25,5 +25,6 @@
     $rectorConfig->skip([
         ClosureToArrowFunctionRector::class,
         JsonThrowOnErrorRector::class,
+        __DIR__ . '/tests/SynchronizerTest.php',
     ]);
 };
diff --git a/tests/SynchronizerTest.php b/tests/SynchronizerTest.php
@@ -57,20 +57,21 @@ public function testExecuteWithErrorCapture(): void
     {
         $result = false;
 
+        $exceptionMessage = null;
         try {
             $this->synchronizer->execute('testExecuteExceptionThrown', function () use (&$result) {
-                $undefined = null;
                 $result = file_exists($this->mutex->getFile());
                 return $undefined;
             });
         } catch (ErrorException $e) {
-            $this->assertSame(
-                PHP_VERSION_ID >= 80000 ? 'Undefined variable $undefined' : 'Undefined variable: undefined',
-                $e->getMessage(),
-            );
-        } finally {
-            $this->assertTrue($result);
-            $this->assertFileDoesNotExist($this->mutex->getFile());
+            $exceptionMessage = $e->getMessage();
         }
+
+        $this->assertSame(
+            PHP_VERSION_ID >= 80000 ? 'Undefined variable $undefined' : 'Undefined variable: undefined',
+            $exceptionMessage,
+        );
+        $this->assertTrue($result);
+        $this->assertFileDoesNotExist($this->mutex->getFile());
     }
 }