db migration #16
db migration #16
Conversation
|
|
||
| public function up(MigrationBuilder $b): void | ||
| { | ||
| $this->createAssignmentsTable($b); |
There was a problem hiding this comment.
Suggest create table here and don't use private method.
There was a problem hiding this comment.
Should I do something here?
There was a problem hiding this comment.
sorry. I thought it was me 😕
composer.json
Outdated
| "yiisoft/db-sqlite": "For using with SQLite", | ||
| "yiisoft/db-mysql": "For using with MySQL", | ||
| "yiisoft/db-pgsql": "For using with PosgtgreSQL", | ||
| "yiisoft/db-mssql": "For using with Microsoft SQL Server", | ||
| "yiisoft/db-oracle": "For using with Oracle", |
There was a problem hiding this comment.
Wouldn't it better mention the only yiisoft/db?
There was a problem hiding this comment.
I don't feel like changing codes. At the moment I'm standardizing all the packages, maybe you've already noticed this.... 🤭 but I think Alexander confirmed to only put the ...db.
There was a problem hiding this comment.
sorry. I thought it was me 😕
Co-authored-by: Sergei Predvoditelev <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #16 +/- ##
========================================
Coverage 0.00% 0.00%
Complexity 26 26
========================================
Files 1 1
Lines 95 95
========================================
Misses 95 95 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Sergei Predvoditelev <[email protected]>
|
Thanks. |
#15