Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rector/rector requirement from ^1.0.3 to ^2.0.3 #21

Merged
merged 2 commits into from
Dec 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/rector.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
on:
pull_request:
pull_request_target:
paths-ignore:
- 'docs/**'
- 'README.md'
Expand All @@ -17,6 +17,7 @@ jobs:
secrets:
token: ${{ secrets.YIISOFT_GITHUB_TOKEN }}
with:
repository: ${{ github.event.pull_request.head.repo.full_name }}
os: >-
['ubuntu-latest']
php: >-
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"require-dev": {
"maglnet/composer-require-checker": "^4.7",
"phpunit/phpunit": "^10.5",
"rector/rector": "^1.0.3",
"rector/rector": "^2.0.3",
"roave/infection-static-analysis-plugin": "^1.34",
"spatie/phpunit-watcher": "^1.23",
"vimeo/psalm": "^5.20"
Expand Down
2 changes: 0 additions & 2 deletions rector.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

use Rector\CodeQuality\Rector\Class_\InlineConstructorDefaultToPropertyRector;
use Rector\Config\RectorConfig;
use Rector\Php73\Rector\FuncCall\JsonThrowOnErrorRector;
use Rector\Php74\Rector\Closure\ClosureToArrowFunctionRector;
use Rector\Php81\Rector\Property\ReadOnlyPropertyRector;
use Rector\Php81\Rector\FuncCall\NullToStrictStringFuncCallArgRector;
Expand All @@ -26,7 +25,6 @@

$rectorConfig->skip([
ClosureToArrowFunctionRector::class,
JsonThrowOnErrorRector::class,
ReadOnlyPropertyRector::class,
NullToStrictStringFuncCallArgRector::class,
]);
Expand Down
4 changes: 2 additions & 2 deletions src/Adapter.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
use Yiisoft\Mutex\MutexFactoryInterface;
use Yiisoft\Mutex\MutexInterface;

final class Adapter implements AdapterInterface

Check failure on line 20 in src/Adapter.php

View workflow job for this annotation

GitHub Actions / psalm / PHP 8.1-ubuntu-latest

UnimplementedInterfaceMethod

src/Adapter.php:20:13: UnimplementedInterfaceMethod: Method getchannelname is not defined on class Yiisoft\Queue\Db\Adapter (see https://psalm.dev/044)

Check failure on line 20 in src/Adapter.php

View workflow job for this annotation

GitHub Actions / psalm / PHP 8.2-ubuntu-latest

UnimplementedInterfaceMethod

src/Adapter.php:20:13: UnimplementedInterfaceMethod: Method getchannelname is not defined on class Yiisoft\Queue\Db\Adapter (see https://psalm.dev/044)

Check failure on line 20 in src/Adapter.php

View workflow job for this annotation

GitHub Actions / psalm / PHP 8.3-ubuntu-latest

UnimplementedInterfaceMethod

src/Adapter.php:20:13: UnimplementedInterfaceMethod: Method getchannelname is not defined on class Yiisoft\Queue\Db\Adapter (see https://psalm.dev/044)
{
/**
* @var MutexInterface Mutex interface.
Expand All @@ -41,9 +41,9 @@
private MessageSerializerInterface $serializer,
private LoopInterface $loop,
private MutexFactoryInterface $mutexFactory,
private string $channel = QueueFactory::DEFAULT_CHANNEL_NAME,

Check failure on line 44 in src/Adapter.php

View workflow job for this annotation

GitHub Actions / psalm / PHP 8.1-ubuntu-latest

UndefinedClass

src/Adapter.php:44:35: UndefinedClass: Class, interface or enum named Yiisoft\Queue\QueueFactory does not exist (see https://psalm.dev/019)

Check failure on line 44 in src/Adapter.php

View workflow job for this annotation

GitHub Actions / psalm / PHP 8.2-ubuntu-latest

UndefinedClass

src/Adapter.php:44:35: UndefinedClass: Class, interface or enum named Yiisoft\Queue\QueueFactory does not exist (see https://psalm.dev/019)

Check failure on line 44 in src/Adapter.php

View workflow job for this annotation

GitHub Actions / psalm / PHP 8.3-ubuntu-latest

UndefinedClass

src/Adapter.php:44:35: UndefinedClass: Class, interface or enum named Yiisoft\Queue\QueueFactory does not exist (see https://psalm.dev/019)
) {
$this->mutex = $this->mutexFactory->create(__CLASS__ . $this->channel);
$this->mutex = $this->mutexFactory->create(self::class . $this->channel);
}

public function runExisting(callable $handlerCallback): void
Expand Down Expand Up @@ -109,7 +109,7 @@

$new = clone $this;
$new->channel = $channel;
$new->mutex = $this->mutexFactory->create(__CLASS__ . $this->channel);
$new->mutex = $this->mutexFactory->create(self::class . $this->channel);

return $new;
}
Expand Down
Loading