Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new console command to listen to multiple queues #167

Merged
merged 12 commits into from
Jan 19, 2024

Conversation

viktorprogger
Copy link
Contributor

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Fixed issues #143

@viktorprogger viktorprogger added the status:code review The pull request needs review. label May 28, 2023
@viktorprogger viktorprogger added this to the 1.0.0-alpha1 milestone May 28, 2023
@viktorprogger viktorprogger requested a review from a team May 28, 2023 13:51
@viktorprogger viktorprogger self-assigned this May 28, 2023
@codecov
Copy link

codecov bot commented May 28, 2023

Codecov Report

Attention: 49 lines in your changes are missing coverage. Please review.

Comparison is base (eba0486) 94.31% compared to head (6c68f37) 89.72%.
Report is 4 commits behind head on master.

Files Patch % Lines
src/Command/ListenAllCommand.php 0.00% 39 Missing ⚠️
src/Message/EnvelopeTrait.php 33.33% 8 Missing ⚠️
src/Message/IdEnvelope.php 80.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #167      +/-   ##
============================================
- Coverage     94.31%   89.72%   -4.60%     
- Complexity      340      359      +19     
============================================
  Files            40       44       +4     
  Lines           915      983      +68     
============================================
+ Hits            863      882      +19     
- Misses           52      101      +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@viktorprogger viktorprogger changed the title Add new console commands to listen to multiple queues Add new console command to listen to multiple queues May 28, 2023
@what-the-diff
Copy link

what-the-diff bot commented May 28, 2023

PR Summary

  • Added ListenAllCommand to Dependency Injection container
    The update introduces a new feature that makes it easier to manage and organize commands.

  • Added default channel definition for yiisoft/config users
    This improvement provides a default channel setup for users of the yiisoft/config package, simplifying the initial configuration steps.

  • Created new command for listening to all configured queues
    This addition provides a convenient way to monitor all configured queues by default if you're using the yiisoft/config package.

@viktorprogger viktorprogger linked an issue May 28, 2023 that may be closed by this pull request
src/Command/ListenAllCommand.php Outdated Show resolved Hide resolved
src/Command/ListenAllCommand.php Show resolved Hide resolved
@samdark
Copy link
Member

samdark commented May 31, 2023

Looks OK but seems to break all tests.

composer.json Outdated Show resolved Hide resolved
@samdark samdark requested a review from xepozz January 18, 2024 16:58
@samdark samdark merged commit 4c918a1 into master Jan 19, 2024
16 of 18 checks passed
@samdark samdark deleted the listen-all-console-command branch January 19, 2024 19:24
@samdark
Copy link
Member

samdark commented Jan 19, 2024

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"multiqueue" worker [feature request]
3 participants