Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve run command #168

Merged
merged 7 commits into from
Jan 18, 2024
Merged

Improve run command #168

merged 7 commits into from
Jan 18, 2024

Conversation

viktorprogger
Copy link
Contributor

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Fixed issues

Two enhancements:

  • Processing messages from different queue channels
  • Ability to set a maximum of jobs to be processed

@viktorprogger viktorprogger added the status:code review The pull request needs review. label May 28, 2023
@viktorprogger viktorprogger added this to the 1.0.0-alpha1 milestone May 28, 2023
@viktorprogger viktorprogger requested a review from a team May 28, 2023 13:56
@viktorprogger viktorprogger self-assigned this May 28, 2023
@codecov
Copy link

codecov bot commented May 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.96 ⚠️

Comparison is base (e60c446) 80.89% compared to head (48e3aff) 79.93%.

❗ Current head 48e3aff differs from pull request most recent head dea3498. Consider uploading reports for the commit dea3498 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #168      +/-   ##
============================================
- Coverage     80.89%   79.93%   -0.96%     
- Complexity      340      341       +1     
============================================
  Files            40       40              
  Lines           921      932      +11     
============================================
  Hits            745      745              
- Misses          176      187      +11     
Impacted Files Coverage Δ
src/Command/RunCommand.php 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@what-the-diff
Copy link

what-the-diff bot commented May 28, 2023

PR Summary

  • New command for processing existing messages
    Added a command to run all existing messages in specified queues.
  • Default channel name update
    Changed the default channel name from 'default' to an empty string.
  • Documentation improvements
    Updated the yiisoft/yii-queue package's documentation, including examples for using Redis, RabbitMQ, and Beanstalkd adapters.

src/Command/RunCommand.php Outdated Show resolved Hide resolved
src/Command/RunCommand.php Show resolved Hide resolved
@viktorprogger viktorprogger merged commit 9ce1388 into master Jan 18, 2024
16 checks passed
@viktorprogger viktorprogger deleted the improve-run-command branch January 18, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants