Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests #172

Merged
merged 5 commits into from
Jul 28, 2023
Merged

Added tests #172

merged 5 commits into from
Jul 28, 2023

Conversation

s1lver
Copy link
Member

@s1lver s1lver commented Jul 24, 2023

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues #27

@s1lver s1lver added the type:test Test label Jul 24, 2023
@what-the-diff
Copy link

what-the-diff bot commented Jul 24, 2023

PR Summary

  • Enhancements in QueueFactoryTest.php
    This update focuses on improving and streamlining the testing process by amending the creation of the 'queue' object. This alteration is accomplished by calling the new getDefaultQueue() private method which creates a default 'Queue' object. Furthermore, there are revisions relating to the configuration of the default channel name.

  • Introduction of New Test Method in JobStatusTest.php
    The addition of a new test method testException() aims to broaden the scope of the testing process. Furthermore, this update introduces support for handling 'InvalidStatusException' and a TestJobStatus class.

  • Creation of a New Test File
    The TestJobStatus.php file is a new addition to the project, located under the tests/Unit/Support/ directory. This will aid in the further expansion of the project's test coverage.

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +7.12% 🎉

Comparison is base (953bee1) 80.89% compared to head (7f38a92) 88.01%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #172      +/-   ##
============================================
+ Coverage     80.89%   88.01%   +7.12%     
+ Complexity      340      338       -2     
============================================
  Files            40       40              
  Lines           921      918       -3     
============================================
+ Hits            745      808      +63     
+ Misses          176      110      -66     
Files Changed Coverage Δ
...pterConfiguration/ChannelIncorrectlyConfigured.php 100.00% <100.00%> (+57.14%) ⬆️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@s1lver s1lver marked this pull request as ready for review July 28, 2023 11:23
@s1lver s1lver merged commit 2b68018 into master Jul 28, 2023
@s1lver s1lver deleted the issue_27 branch July 28, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants