Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debug collector + Disable Yii Config plugin #179

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Fix debug collector + Disable Yii Config plugin #179

merged 3 commits into from
Nov 22, 2023

Conversation

vjik
Copy link
Member

@vjik vjik commented Nov 21, 2023

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues -

Copy link

what-the-diff bot commented Nov 21, 2023

PR Summary

  • Update to Project's Configuration File
    The composer.json file, which is used to manage the project's dependencies and settings, had a value updated. The configuration for the "yiisoft/config" plugin (a tool managing the configuration files) was explicitly set to false, meaning it would not be allowed to execute.

  • Enhancement to Debugging Capabilities
    There were updates to the QueueCollector.php file, which is a part of the project's debugging capabilities. New checks were added to the 'getCollected' and 'getSummary' functions. They ensure only meaningful data is returned by these methods. If the Debug environment isn't active, these methods will now correctly return an empty array instead of attempting to collect non-existent information.

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (027989a) 94.22% compared to head (d902a44) 94.36%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #179      +/-   ##
============================================
+ Coverage     94.22%   94.36%   +0.13%     
- Complexity      338      340       +2     
============================================
  Files            40       40              
  Lines           918      922       +4     
============================================
+ Hits            865      870       +5     
+ Misses           53       52       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik requested a review from a team November 21, 2023 18:44
@vjik vjik added the status:code review The pull request needs review. label Nov 21, 2023
@vjik vjik merged commit 339d713 into master Nov 22, 2023
17 checks passed
@vjik vjik deleted the fix-collector branch November 22, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants