Merge Push and Consume middlewares #189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a concern about this change because push/consume middleware are not interchangeable and two interfaces were introduced on purpose according to @viktorprogger |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #189 +/- ##
============================================
- Coverage 83.98% 82.47% -1.52%
+ Complexity 359 319 -40
============================================
Files 46 42 -4
Lines 1049 947 -102
============================================
- Hits 881 781 -100
+ Misses 168 166 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.