Ability to find an envelope instance from the given stack #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samdark
requested changes
Sep 20, 2024
| public function getEnvelopeFromStack(string $className): EnvelopeInterface | ||
| { | ||
| if (!is_a($className, EnvelopeInterface::class, true)) { | ||
| throw new NotEnvelopInterfaceException($className); |
There was a problem hiding this comment.
Suggested change
| throw new NotEnvelopInterfaceException($className); | |
| throw new NotEnvelopeException($className); |
| use InvalidArgumentException; | ||
| use Throwable; | ||
|
|
||
| final class NotEnvelopInterfaceException extends InvalidArgumentException |
There was a problem hiding this comment.
Suggested change
| final class NotEnvelopInterfaceException extends InvalidArgumentException | |
| final class NotEnvelopeException extends InvalidArgumentException |
|
This approach will return an unwanted value in case it is overwritten somewhere in stack by an envelope with another class name. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to obtain an envelope instance from envelope stack:
If the envelope you need uses
EnvelopeTrait, it's more simple: codeIdEnvelope::getEnvelopeFromMessage($message)will have the same effect as above.