-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify envelopes #217
Closed
Closed
Simplify envelopes #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samdark
approved these changes
Oct 13, 2024
# Conflicts: # src/Message/EnvelopeTrait.php # src/Message/JsonMessageSerializer.php # tests/Unit/Message/JsonMessageSerializerTest.php
Trait to abstract class conversion is moved to #231, other changes slow down this package too much |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the Envelope concept. The main changes are:
EnvelopeTrait
is converted intoAbstractEnvelope
class.With these changes it's dimpler to debug an application with envelopes. It's also becomes simple and meaningful to use unique method of envelopes be envelope creation in place like this, because there is no more a deep envelope stack with a recursive data search: