Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrency in items storage tests, handle not found base item in access tree #237

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

arogachev
Copy link
Contributor

Q A
Is bugfix?
New feature?
Breaks BC?

@arogachev arogachev self-assigned this Feb 1, 2024
@arogachev arogachev added this to the 2.0 milestone Feb 1, 2024
@arogachev arogachev added the type:test Test label Feb 1, 2024
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d29f2c7) 100.00% compared to head (40af722) 99.81%.

❗ Current head 40af722 differs from pull request most recent head 8d7365b. Consider uploading reports for the commit 8d7365b to get more accurate results

Files Patch % Lines
src/SimpleItemsStorage.php 50.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##              master     #237      +/-   ##
=============================================
- Coverage     100.00%   99.81%   -0.19%     
- Complexity       215      216       +1     
=============================================
  Files             13       13              
  Lines            537      539       +2     
=============================================
+ Hits             537      538       +1     
- Misses             0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arogachev arogachev added the type:bug Bug label Feb 1, 2024
Copy link

what-the-diff bot commented Feb 1, 2024

PR Summary

  • Improved error handling in item storage
    We've made a modification to throw an exception in the SimpleItemsStorage.php file when a base item is not found. Now, this will allow more regular system behavior and easier bug tracking.

  • Code Refactoring in item storage test
    Several changes were made to ItemsStorageTestTrait.php where we updated the variable name from $storage to $actionStorage in various test methods. This was done to make the code more understandable, and align the variable naming more specifically to its usage regarding action-related storage operations. Furthermore, we updated these methods' assertions (checks performed during testing) to use $testStorage representing the test storage.

This refactoring effort will make the file more maintainable and present tests in a more understandable way. It is a significant step in ensuring our testing environment's robustness, leading to a more reliable product.

@arogachev arogachev merged commit 175ae16 into master Feb 1, 2024
2 of 3 checks passed
@arogachev arogachev deleted the item-storage-concurrency branch February 1, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant