Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes #244

Merged
merged 6 commits into from
Feb 12, 2024
Merged

Minor fixes #244

merged 6 commits into from
Feb 12, 2024

Conversation

samdark
Copy link
Member

@samdark samdark commented Feb 11, 2024

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

@samdark samdark requested a review from arogachev February 11, 2024 20:57
Copy link

codecov bot commented Feb 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (238f828) 100.00% compared to head (d989b95) 100.00%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #244   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       216       217    +1     
===========================================
  Files             13        13           
  Lines            539       546    +7     
===========================================
+ Hits             539       546    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

what-the-diff bot commented Feb 11, 2024

PR Summary

  • Updated PHP Version Requirement in README.md
    The requirement for the PHP version has been updated to 8.1 or higher. This ensures that the program will run optimally on up-to-date installations of PHP.

  • Improved Documentation across multiple files
    The documentation across multiple files like AssignmentsStorageInterface.php, ItemsStorageInterface.php, ManagerInterfact.php, and RuleInterface.php has been updated, improving the readability and understanding of the code.

  • Added 'readonly' modifier to certain properties across multiple files
    The readonly modifier has been added to properties in Assignment.php, CompositeRule.php, Manager.php, etc. This ensures that once a property is initialized, it cannot be changed. It provides a higher level of security and helps reduce coding errors.

  • Code enhancements and bug fixes

    • SimpleItemsStorage's getByNames method now uses strict comparison, providing more accurate results.
    • RuleContextTest has updated the assertion statement, improving test accuracy.
    • Removed the property $reCreateAssignmentsStorageAfterModifications from AssignmentsStorageTestTrait to simplify and optimize the testing process.
  • Enhanced readability with grammar improvements
    Fixed typos and improved grammar in the README documentation files.

These changes aim to improve the overall functionality, security and readability of the program, making it easier and safer to use.

@arogachev arogachev merged commit e849ca1 into master Feb 12, 2024
23 of 25 checks passed
@arogachev arogachev deleted the fixes branch February 12, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants