Add new class RequestHeaders #14
Conversation
DikoIbragimov
commented
Dec 11, 2024
DikoIbragimov
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ✔️ |
| Breaks BC? | ❌ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 6 16 +10
===========================================
Files 3 5 +2
Lines 13 32 +19
===========================================
+ Hits 13 32 +19 ☔ View full report in Codecov by Sentry. |
…ding new methods for getting request headers in different formats and corresponding tests
|
I'd recommended to think about providing (setting) custom headers like error-handler does. |
|
|
||
| namespace Yiisoft\RequestProvider; | ||
|
|
||
| final class RequestHeaders { |
There was a problem hiding this comment.
| final class RequestHeaders { | |
| final class RequestHeaderProvider { |
There was a problem hiding this comment.
Suggested name is not consistent with RequestCookies.
There was a problem hiding this comment.
RequestCookies is inconsistent with the rest Yii3 packages as well
There was a problem hiding this comment.
Agree. RequestHeaderProvider is better name.
There was a problem hiding this comment.
Maybe a RequestHeaderCollection?
There was a problem hiding this comment.
Also good, but it's not a classic collection. Very custom implementation that depends on another class. It's more proxy than collection.
ProxyCollection? 😁
| use Yiisoft\RequestProvider\RequestHeaders; | ||
| use Yiisoft\RequestProvider\RequestProviderInterface; | ||
|
|
||
| final class RequestHeadersTest extends TestCase { |
There was a problem hiding this comment.
| final class RequestHeadersTest extends TestCase { | |
| final class RequestHeaderProviderTest extends TestCase { |
Co-authored-by: Rustam Mamadaminov <[email protected]>
