Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #19: Remove RequestCookies #21

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix #19: Remove RequestCookies #21

wants to merge 5 commits into from

Conversation

FrankiFixx
Copy link

Q A
Is bugfix? ❌
New feature? ❌
Breaks BC? ❌

@codecov Codecov
Copy link

codecov bot commented Jan 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7c4d671) to head (5f5138f).
Report is 26 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff             @@
##              master       #21   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity         6        16   +10     
===========================================
  Files              3         5    +2     
  Lines             13        32   +19     
===========================================
+ Hits              13        32   +19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vjik
vjik requested changes Jan 14, 2025
View reviewed changes
Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!
We won't merge this PR yet, we'll wait another BC-breaked changes in package, then merge it.

tests/RequestCookiesTest.php Outdated Show resolved Hide resolved
vjik
vjik reviewed Jan 14, 2025
View reviewed changes
Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add line to changelog.

samdark
samdark approved these changes Jan 14, 2025
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@samdark samdark requested a review from vjik January 14, 2025 22:37
vjik
vjik reviewed Jan 16, 2025
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@vjik vjik changed the title Fix #19, remove RequestCookies, rewrite tests for cookies from request Fix #19: Remove RequestCookies Jan 16, 2025
@vjik vjik added the status:ready for merge The pull request is OK to be merged. label Jan 16, 2025
vjik
vjik approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll merge it after other BC-break changes are added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark approved these changes

@vjik vjik vjik approved these changes

Assignees
No one assigned
Labels
status:ready for merge The pull request is OK to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FrankiFixx @samdark @vjik