Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw InvalidArgumentException when missed "one" plural key + Fix psalm #131

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

vjik
Copy link
Member

@vjik vjik commented Feb 12, 2024

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

Copy link

what-the-diff bot commented Feb 12, 2024

PR Summary

  • Enhanced Workflow Triggers
    Addition of master branch to the push event trigger. This allows actions to be automatically run in GitHub workflows whenever code is pushed to the master branch.

  • Enhanced Error Handling
    Enhanced issue Throw InvalidArgumentException when missed "one" plural key + Fix psalm #131 by throwing an InvalidArgumentException to provide clear, concise information when invalid arguments are used.

  • Dependency Upgrades
    Updated core testing library phpunit/phpunit, enhanced code quality checker vimeo/psalm, and included the configuration file psalm80.xml to setup project with the latest versions.

  • Enhanced Code Quality Checks
    Added <issueHandlers> element and suppressed error levels for specified tests in psalm.xml to reduce noise in code quality reports.

  • Code Quality Configuration
    Added psalm80.xml with configurations and rules to maintain high-quality code according to the standards of Psalm version 80.

  • Improved Message Formatting
    A new check in SimpleMessageFormatter.php was added to ensure the validity of the message format and throw an InvalidArgumentException if key parts are missing.

  • Improved Test Names
    Renamed a test method to better communicate its purpose, increasing readability of tests.

  • New Test Method Added
    New test method to check specific key existence to ensure robustness of code against unusual cases.

@vjik vjik requested a review from a team February 12, 2024 17:32
@vjik vjik added the status:code review The pull request needs review. label Feb 12, 2024
@vjik vjik merged commit be26af7 into master Feb 13, 2024
30 checks passed
@vjik vjik deleted the fix-psalm branch February 13, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants