Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect locale usage when message ID is not exist #132

Merged
merged 4 commits into from
Feb 25, 2024
Merged

Fix incorrect locale usage when message ID is not exist #132

merged 4 commits into from
Feb 25, 2024

Conversation

vjik
Copy link
Member

@vjik vjik commented Feb 22, 2024

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues -

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.35%. Comparing base (ee746d9) to head (fc177d8).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #132   +/-   ##
=========================================
  Coverage     99.34%   99.35%           
- Complexity      110      111    +1     
=========================================
  Files            13       13           
  Lines           306      308    +2     
=========================================
+ Hits            304      306    +2     
  Misses            2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

what-the-diff bot commented Feb 22, 2024

PR Summary

  • Changelog Update

  • Method Enhancement in Translator.php

    • Simplified the translation process by optimizing the translateUsingCategorySources method. This should result in smoother and more reliable translations.
  • Unit Testing Improvements in TranslatorTest.php

    • Expanded the unit test coverage by adding a new test method and various scenarios for it in testDefaultMessageFormatterWithoutId.
    • Enhanced the accuracy of an existing test case by using a more realistic message for translation.

@vjik vjik requested a review from a team February 22, 2024 14:24
@vjik vjik added the status:code review The pull request needs review. label Feb 22, 2024
tests/TranslatorTest.php Outdated Show resolved Hide resolved
@vjik vjik added status:under development Someone is working on a pull request. and removed status:code review The pull request needs review. labels Feb 24, 2024
@vjik vjik requested a review from darkdef February 24, 2024 14:09
@vjik vjik added status:code review The pull request needs review. and removed status:under development Someone is working on a pull request. labels Feb 24, 2024
@vjik vjik requested a review from a team February 24, 2024 14:10
@vjik vjik merged commit 745a810 into master Feb 25, 2024
32 checks passed
@vjik vjik deleted the fix branch February 25, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants