generated from yiisoft/package-template
-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect locale usage when message ID is not exist #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vjik
commented
Feb 22, 2024
Q | A |
---|---|
Is bugfix? | ✔️ |
New feature? | ❌ |
Breaks BC? | ❌ |
Fixed issues | - |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #132 +/- ##
=========================================
Coverage 99.34% 99.35%
- Complexity 110 111 +1
=========================================
Files 13 13
Lines 306 308 +2
=========================================
+ Hits 304 306 +2
Misses 2 2 ☔ View full report in Codecov by Sentry. |
PR Summary
|
darkdef
reviewed
Feb 24, 2024
vjik
added
status:under development
Someone is working on a pull request.
and removed
status:code review
The pull request needs review.
labels
Feb 24, 2024
vjik
added
status:code review
The pull request needs review.
and removed
status:under development
Someone is working on a pull request.
labels
Feb 24, 2024
samdark
approved these changes
Feb 25, 2024
darkdef
approved these changes
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.