Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests #185

Merged
merged 4 commits into from
Jan 30, 2024
Merged

Add unit tests #185

merged 4 commits into from
Jan 30, 2024

Conversation

msmakouz
Copy link
Contributor

@msmakouz msmakouz commented Jan 30, 2024

Q A
Is bugfix?
New feature?
Breaks BC?

Part of #22

Copy link

what-the-diff bot commented Jan 30, 2024

PR Summary

  • Added and Enhanced Test Cases
    This PR introduced new test cases to CreateCommandTest.php, DownCommandTest.php, and GenerateCommandTest.php. These test cases will help ensure that our system operates as expected and immediately pinpoint any issues that may arise from changes.
  • Unchanged Test File
    No changes were made to ListCommandTest.php, ensuring that the existing tests are still valid and relevant.
  • Introduction of Test Case Class
    A PHPUnit test case class was introduced in a new file TestCase.php, which aids in creating uniform and reusable test sets.
  • Enhancements to Existing Test Files
    Multiple existing test files were modified, such as UpCommandTest.php, EntityReaderTest.php, AllHandlerTest.php, and AnyHandlerTest.php. In particular, these enhancements included adding tests to ensure different scenarios and edge cases are thoroughly checked.
  • New Test Files
    Several new test files were added, including ones for classes like FromConveyorSchemaProvider, CachedCollection, CachedCount, and EntityReader. This further broadens our test coverage and ensures all code units function as expected.
  • New Filter Handlers Test
    Newly added files InHandlerTest.php and LikeHandlerTest.php in the tests/Unit/Data/Reader/FilterHandler directory will verify the functioning of these respective filter handlers.
  • New Exception Test Files
    The PR added new test files NotFoundExceptionTest.php and NotInstantiableClassExceptionTest.php in the tests/Unit/Exception directory. These help check our system's response when encountering exceptions.
  • Factory Class Test
    A new test file named DbalFactoryTest.php was introduced in the tests/Unit/Factory/DbalFactory directory to test the correctness and reliability of our factory class.

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea138b3) 84.53% compared to head (21ee51b) 93.55%.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.0     #185      +/-   ##
============================================
+ Coverage     84.53%   93.55%   +9.01%     
  Complexity      375      375              
============================================
  Files            58       58              
  Lines          1009     1009              
============================================
+ Hits            853      944      +91     
+ Misses          156       65      -91     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msmakouz msmakouz force-pushed the tests branch 2 times, most recently from b1ab0be to 71ef96e Compare January 30, 2024 17:31
@roxblnfk roxblnfk merged commit cb103f0 into yiisoft:2.0 Jan 30, 2024
13 checks passed
@roxblnfk roxblnfk added the type:test Test label Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants