Refactor BacktraceIgnoreMatcher
#304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vjik
commented
Jan 19, 2025
vjik
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ❌ |
| Breaks BC? | ✔️ |
xepozz
requested changes
Jan 19, 2025
| @@ -105,8 +105,8 @@ public static function unregister(): void | |||
| private function isIgnored(): bool | |||
| { | |||
| $backtrace = debug_backtrace(); | |||
| return BacktraceIgnoreMatcher::isIgnoredByClass($backtrace, self::$ignoredClasses) | |||
| || BacktraceIgnoreMatcher::isIgnoredByFile($backtrace, self::$ignoredPathPatterns); | |||
| return BacktraceMatcher::byClass($backtrace[3], self::$ignoredClasses) | |||
There was a problem hiding this comment.
What could either byClass or byFile method mean?
Can't see any improvements here
There was a problem hiding this comment.
Backtrace match (class name) by file/class (method name).
"Ignore" doesn't matter here.
There was a problem hiding this comment.
- if you rename a class rename it instead of removing and adding a new one
- a class method must be a verb
- better name for the methods should contain
contains/includes/intersects'cause it contains searching operation - the matcher now depends on the proxy implementation, which was independent before and could be used in any other flows
There was a problem hiding this comment.
- if you rename a class rename it instead of removing and adding a new one
That is what GitHub decided, not me :)
- a class method must be a verb
- better name for the methods should contain
contains/includes/intersects'cause it contains searching operation
I don't think it makes sense in this case, because all methods perform single action. But it doesn't matter to me. Is "matchByFile()“ OK?
- the matcher now depends on the proxy implementation, which was independent before and could be used in any other flows
On the contrary, now the matcher could be used in any other flows, because it not depends from internal structure of calling class (It depends on which item of backtrace to use for matching).
vjik
force-pushed
the
backtrace-matcher
branch
from
3384c86 to
9ccf813
Compare
samdark
approved these changes
Jan 21, 2025
xepozz
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.